-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Demonstrating use of composite ids. #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* @see InsertRepository | ||
* @see InsertRepositoryImpl | ||
*/ | ||
interface EmployeeRepository extends ListCrudRepository<Employee, EmployeeId>, InsertRepository<Employee> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using fewer dependencies (i.e. just Repository
) would be a welcome simplification as that is what we advocate for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
* @author Jens Schauder | ||
*/ | ||
class InsertRepositoryImpl<E> implements InsertRepository<E> { | ||
@Autowired |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Please use constructor injection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge this one and the blog once going over the comments.
Doing this as part of the relational composite id example, since we depend on that mile sone as well. Original pull request #696
Did all the changes as merged it. This includes the upgrade for the AOT examples. |
This goes with the blog article about composite ids.